Conversation
popescu-v
reviewed
Sep 24, 2026
| ) | ||
| self.assertEqual(output_error_msg, expected_msg) | ||
|
|
||
| def test_pandas_table_column_value_must_accept_all_string_variants(self): |
Collaborator
There was a problem hiding this comment.
Move the test to test_dataset_class.py, because no error / failure-mode is checked here; just normal behavior.
popescu-v
reviewed
Sep 24, 2026
| khiops_type = "Numerical" | ||
| elif lower_numpy_type == "string": | ||
| # A unique test to catch both cases where lower_numpy_type is "str" or "string" | ||
| elif isinstance(numpy_type, pd.StringDtype): |
Collaborator
There was a problem hiding this comment.
For a minimally-invasive change, I'd do just:
elif lower_numpy_type in ["str", "string"]Otherwise, the scope would be larger than the support Khiops is committed to (just Pandas, with its NumPy dependency, plus SciPy - for the sparse data):
isinstance(pd.StringDtype(storage="pyarrow"), pd.StringDtype) # => True
str(pd.StringDtype(storage="pyarrow")).lower() in ("string", "str") # => False, because "string[pyarrow]" not in ["string", "str"]Adding further support (PyArrow, BigQuery) seems out of the scope of the current PR and deserves further assessment IMHO.
Collaborator
Author
There was a problem hiding this comment.
You are right. I changed the test
- All the numpy string dtypes ('str' and 'string') must be considered
tramora
force-pushed
the
str_string_dtypes_sklearn
branch
from
September 25, 2026 08:39
3a4e269 to
376fce7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #607
TODO Before Asking for a Review
main(ormain-v10)Unreleasedsection ofCHANGELOG.md(no date)index.html