Skip to content

Enable System Parameters Globally #622 - #624

Draft
lucaurelien wants to merge 3 commits into
mainfrom
opsx-enable-system-parameters-gobally
Draft

Enable System Parameters Globally #622#624
lucaurelien wants to merge 3 commits into
mainfrom
opsx-enable-system-parameters-gobally

Conversation

@lucaurelien

@lucaurelien lucaurelien commented Sep 22, 2026

Copy link
Copy Markdown
Member

No description provided.

@lucaurelien
lucaurelien force-pushed the opsx-enable-system-parameters-gobally branch from 93f0b5f to dc8b9c5 Compare September 22, 2026 19:26
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread doc/site/notes.md Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread doc/site/notes.md Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread doc/site/notes.md
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/api.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/api.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/api.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/api.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/api.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/api.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread tests/test_core.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread tests/test_core.py Outdated
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread tests/test_khiops_integrations.py Outdated
popescu-v
popescu-v requested changes Sep 23, 2026
View reviewed changes

@popescu-v popescu-v left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments.

@lucaurelien
lucaurelien force-pushed the opsx-enable-system-parameters-gobally branch from cbf441a to 33592a3 Compare September 23, 2026 15:11
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread khiops/core/internals/runner.py
popescu-v
popescu-v reviewed Sep 23, 2026
View reviewed changes
Comment thread .gitignore Outdated
popescu-v
popescu-v requested changes Sep 23, 2026
View reviewed changes

@popescu-v popescu-v left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments.

popescu-v
popescu-v reviewed Sep 24, 2026
View reviewed changes
Comment thread tests/test_khiops_integrations.py
f"KHIOPS_PATH {tool_path}\n"
f"KHIOPS_COCLUSTERING_PATH {tool_path}\n"
"KHIOPS_MPI_COMMAND mpiexec\n"
"KHIOPS_API_MODE false\n"

@popescu-v popescu-v Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this to True (always the case from Python).

popescu-v
popescu-v reviewed Sep 24, 2026
View reviewed changes
Comment thread tests/test_khiops_integrations.py
f"KHIOPS_COCLUSTERING_PATH {tool_path}\n"
"KHIOPS_MPI_COMMAND mpiexec\n"
"KHIOPS_API_MODE false\n"
"KHIOPS_RETURNED yes\n",

@popescu-v popescu-v Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove (does not exist).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@popescu-v popescu-v popescu-v requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucaurelien @popescu-v