test(chart): shardsplitjobs RBAC 렌더 회귀 가드 + .editorconfig 정합#264
Open
KeiaiLab-PHIL wants to merge 1 commit into
Open
test(chart): shardsplitjobs RBAC 렌더 회귀 가드 + .editorconfig 정합#264KeiaiLab-PHIL wants to merge 1 commit into
KeiaiLab-PHIL wants to merge 1 commit into
Conversation
…C + .editorconfig #262 가 helm 차트 ClusterRole 에 shardsplitjobs/shardranges RBAC 누락(issue #260) 을 보강했으나 회귀 테스트는 추가하지 않았다. 차트 RBAC 은 config/rbac/role.yaml (controller-gen 정본)을 손으로 옮긴 사본이라, 향후 CRD 추가 시 동일 drift 가 재발 하기 쉽다. 변경: - test/chart/rbac_clusterrole_test.go: 렌더된 manager ClusterRole 에 shardranges/ shardsplitjobs(get,list,watch,update,patch) + shardsplitjobs/status(get,update, patch) 규칙 존재를 helm-template 하네스(기존 grafana_dashboards_test.go 재사용)로 단언. config/rbac/role.yaml 과의 향후 drift 를 렌더 레벨에서 차단. - .editorconfig: sibling operator(mongodb/valkey, blob 397f9c0) byte-동일 추가. 검증: - go test ./test/chart/ -run TestManagerClusterRole -count=1 → ok (origin/main #262 RBAC 에 대해 PASS; 수정 전 차트로는 FAIL = 진정한 가드 입증) - go build ./... / make fmt / make vet → exit 0 Refs #260 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
#262가 helm 차트 manager ClusterRole 의shardsplitjobs/shardrangesRBAC 누락(issue #260, operator watch forbidden loop)을 보강했으나 회귀 테스트는 동반하지 않았다. 차트 RBAC 은config/rbac/role.yaml(controller-gen 정본)을 손으로 옮긴 사본이라, 향후 CRD 추가 시 동일 drift 가 재발하기 쉽다. 본 PR 은 그 fix 를 렌더 레벨에서 잠그는 회귀 가드 + sibling operator 정합.editorconfig를 추가한다.변경
test/chart/rbac_clusterrole_test.go(신규): 렌더된 manager ClusterRole 에shardranges/shardsplitjobs(verbsget,list,watch,update,patch) +shardsplitjobs/status(get,update,patch) 규칙 존재를 단언. 기존grafana_dashboards_test.go의 helm-template 하네스 재사용.config/rbac/role.yaml과의 향후 drift 를 차단..editorconfig(신규): mongodb-operator/valkey-operator 와 byte-동일(blob397f9c0d). 편집기별 들여쓰기/개행 불일치 해소.검증
Refs #260