Skip to content

MiniMods - #27

Open
Spartwo wants to merge 6 commits into
KSPModdingLibs:mainfrom
Spartwo:main
Open

Spartwo wants to merge 6 commits into
KSPModdingLibs:mainfrom
Spartwo:main

Conversation

@Spartwo

@Spartwo Spartwo commented Sep 13, 2026

Copy link
Copy Markdown
  • ModuleToggleTracking
  • ModuleAttachmentVisuals
  • ModuleExclusiveResourceConverter

@Spartwo

Spartwo commented Sep 13, 2026

Copy link
Copy Markdown
Author

// Parse attachment nodes
if (!string.IsNullOrWhiteSpace(requiredNodes))
{
foreach (string nodeName in requiredNodes.Split(','))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about allowing the requiredNodes key to be specified more than once, rather than splitting by commas? That tends to work better with MM patches.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does sound a bit more standard.

The commas are a leftover from the previous module version which clustered every node group into one. The commas were used like seperators in parallel lists to have them paired up.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transform list is liable to become quite long and other mods take the comma approach(well, semicolon, but I'd changed the split identifier just now)

Working from patches its'a already very flexible

Comment thread Source/Modules/ModuleAttachmentVisuals.cs
Module is event driven and doesn't run inflight. disabled the frame behaviour
@Spartwo

Spartwo commented Sep 20, 2026

Copy link
Copy Markdown
Author

Put a hold on this, I wish to add localisation support for the display name

The display name for the attachment visuals didn't have loc reference support

isEnabled had turned off the capping toggle

added general loc references using squad cfgs
@Spartwo

Spartwo commented Sep 20, 2026

Copy link
Copy Markdown
Author

@JonnyOThan Appropriate changes made and the missing loc support has been added

Added new modules with descriptions for ModuleAttachmentVisuals, ModuleExclusiveResourceConverter, and ModuleToggleTracking.
Update README with new module descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants