complete url-graph filter sync, implement share, add no data feedback #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprint
#50
Who worked on this sprint?
Anne Wu, Jack Liu
Features Implemented
Syncing graph URL to graph filters & settings
Added no matching data found feedback
Implemented Share
New files created
N/A
Existing files modified
/src/app/graphs/page.tsx
/src/app/layout.tsx
/src/app/components/graphFilters/graphFilters.tsx
Acceptance Criteria
Test as many combinations of parsing and embedding as you can. Full functionality is expected from the embedder/parser at the end of the ticket
Default configuration does not include any active filters
Test share button to ensure that the correct URL is copied to clipboard
UI matches Figma
Code runs locally without errors and builds successfully
Merge via PR
Testing: how did you test?
Tested a bunch of different filters, copying url and making sure the resultant page is still the same.
Tested different year ranges, graph settings, etc.
Features Not Implemented/Incomplete
N/A
Screenshots:
Tag Dan and Shayne
@danglorioso @shaynesidman