Restore HTTP.Exceptions as a deprecating compat shim + migration note#1315
Open
mathieu17g wants to merge 1 commit into
Open
Restore HTTP.Exceptions as a deprecating compat shim + migration note#1315mathieu17g wants to merge 1 commit into
HTTP.Exceptions as a deprecating compat shim + migration note#1315mathieu17g wants to merge 1 commit into
Conversation
Re-add HTTP.Exceptions as a thin deprecated submodule forwarding HTTPError, StatusError, ConnectError and TimeoutError to the canonical top-level names via Base.@deprecate_binding (as the existing escape -> escapeuri), so downstream `catch ... isa HTTP.Exceptions.StatusError` keeps working with a deprecation warning. RequestError, @Try and current_exceptions_to_string are not reinstated; the migration guide documents them (RequestError has no drop-in -- the underlying exception propagates and isrecoverable classifies it). Closes JuliaWeb#1314.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1315 +/- ##
==========================================
- Coverage 87.32% 87.17% -0.16%
==========================================
Files 29 29
Lines 11326 11326
==========================================
- Hits 9890 9873 -17
- Misses 1436 1453 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the deprecating
HTTP.Exceptionsshim and migration note discussed in #1314 (context and prevalence there).src/HTTP.jlre-addsHTTP.Exceptionsas a thin deprecated submodule forwarding the four relocated types to their top-level names:So
catch … isa HTTP.Exceptions.StatusErrorresolves again, forwarding toHTTP.StatusErrorwith a--depwarn=yeswarning — same mechanism as the existing@deprecate escape escapeuri, and like it, untested.RequestError,@try, andcurrent_exceptions_to_stringare not reinstated; the migration note covers them (RequestErrorhas no drop-in — the underlying exception propagates andisrecoverableclassifies it, #1310).docs/src/guides/migration-1x.mdgains an "Exceptions" section (Before/After forStatusErrorandRequestError) and a Final-Checklist line.Closes #1314.