DiagonalBFGSModel#127
DiagonalBFGSModel#127MohamedLaghdafHABIBOULLAH wants to merge 1 commit intoJuliaSmoothOptimizers:mainfrom
Conversation
|
We need a |
|
We already have it, don't we? https://github.com/JuliaSmoothOptimizers/NLPModelsModifiers.jl/blob/main/src/quasi-newton.jl#L214 |
|
@dpo pourrais tu me donner ton avis sur cette PR ? |
|
I don’t think we want to maintain a nondiagonal LBFGS operator just to construct this one. |
|
I don't quite get it. I did the same for other diagonal quasi-Newton updates, such as DiagonalPSBModel, DiagonalAndreiModel, and SpectralGradientModel, for which we have already defined quasi-Newton linear operators within LinearOperators.jl. Should I do the same for all other diagonal updates and use only the quasi-Newton linear operators ? |
|
There is no DiagonalBFGS operator in LinearOperators: https://github.com/search?q=repo%3AJuliaSmoothOptimizers%2FLinearOperators.jl%20DiagonalBFGS&type=code |
That's why I opened this PR DBFGS |
|
Before we can test this, we need a new release of LinearOperators and we need to update Project.toml here. |
|
So should I open a PR to bump the version of LinearOperators.jl? |
632537a to
1f98506
Compare
Add DiagonalBFGSModel where the hessian is approximated by DiagonalBFGS from LinearOperators.jl