Skip to content

rm duplicate topologykind #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Affie merged 1 commit into from
May 12, 2026
+1 −4
Merged

rm duplicate topologykind #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,4 +798,4 @@ refPoints(state::State) = state.belief.points
refBandwidth(state::State) = state.belief.trailing_forms[1]
refBandwidths(state::State) = SparseArrays.nonzeros(state.belief.trailing_forms)
refObservability(state::State) = state.belief.observability
getTopologyKind(state::State) = state.belief.topologykind
getTopologyKind(state::State) = state.belief.reprkind.topologykind
3 changes: 0 additions & 3 deletions src/entities/HomotopyDensity.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ provided by AMP for features like pdf evaluation.
how to interpret this object. By analogy, and image is an image, but might be stored bitmap, jpeg, png, and use RGB24, YCbCr, etc."""
reprkind::HomotopyReprDFG{T} =
HomotopyReprDFG(DefaultTopologyKind(), DefaultFormKind(), T(), nothing)
"""A hint for downstream solvers on how to interpret this data (The 'How')"""
topologykind::AbstractHomotopyTopology = DefaultTopologyKind()
"""Stores the amount of information captured in each coordinate dimension."""
observability::Vector{Float64} = Float64[] #zeros(getDimension(T)) #TODO renamed from infoPerCoord in v0.29
"""
Expand Down Expand Up @@ -122,7 +120,6 @@ function StructUtils.fielddefaults(
::Type{HomotopyDensityDFG{T, P}},
) where {T, P}
return (
topologykind = DefaultTopologyKind(),
observability = Float64[],
principal_coeffs = Float64[],
principal_elements = P[],
Expand Down
Loading