Fix ELF symbol indexing for explicit sections#62
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 69.75% 69.94% +0.19%
==========================================
Files 46 46
Lines 1362 1364 +2
==========================================
+ Hits 950 954 +4
+ Misses 412 410 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ELFSymbols can be constructed directly from a section, such as .dynsym, but the generic Symbols.getindex path read entries from symtab_entry_offset(handle(syms)). For ELF that re-runs Symbols(oh) and usually selects .symtab, leaving explicit .dynsym objects with entries read from .symtab and names resolved through .dynstr. Add an ELF-specific getindex method that reads from Section(syms), preserving the symbol table selected by Symbols(section). This fixes explicit .dynsym indexing semantics and also avoids repeatedly rediscovering the object-level preferred table on large binaries. Cover the regression with bundled ELF fixtures by checking a known .dynsym entry.
maleadt
force-pushed
the
tb/fix_elf_symbol_indexing
branch
from
0c16865 to
3416629
Compare
maleadt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELFSymbols can be constructed directly from a section, such as .dynsym, but the generic Symbols.getindex path read entries from symtab_entry_offset(handle(syms)). For ELF that re-runs Symbols(oh) and usually selects .symtab, leaving explicit .dynsym objects with entries read from .symtab and names resolved through .dynstr.
Add an ELF-specific getindex method that reads from Section(syms), preserving the symbol table selected by Symbols(section). This fixes explicit .dynsym indexing semantics and also avoids repeatedly rediscovering the object-level preferred table on large binaries.
Cover the regression with bundled ELF fixtures by checking a known .dynsym entry.