Normalize unit-sphere geometry input to longitude/latitude - #20
Open
asinghvi17 wants to merge 4 commits into
Open
asinghvi17 wants to merge 4 commits into
asinghvi17 wants to merge 4 commits into
Conversation
asinghvi17
added this pull request to stack #18
September 20, 2026 20:35
asinghvi17
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spherical lookups now accept GeometryOps
UnitSphericalPointinput, including points inside lines and polygons, and normalize it to longitude/latitude at construction and query boundaries. Tables and raster point extraction therefore emit coordinates that other geometry consumers can use.The conversion preserves supplied geographic CRS metadata and works with the preceding datum-resolution layer. USP's intrinsic Cartesian CRS is excluded from inferred geographic metadata; a table explicitly declaring that internal CRS is rejected with guidance to supply the geographic CRS. Ordinary three-coordinate points are unchanged.
Scalar USP selectors are disambiguated from vector selectors for
At,Near,Contains, DE9IM predicates, andhasselection. Indexed spherical nearest queries from the preceding PR remain in place.Validation: 44 USP assertions pass on Julia 1.10 and 1.13, covering conversion, selectors, table and extraction output, bare USP input, custom datums, and missing CRS. The combined construction, datum, and nearest suites also pass on both versions. This is the fourth PR in the GitHub stack.
The complete combined suite passes on Julia 1.13: 2,470 assertions, including the existing planar, raster, table, and Makie tests. The no-Proj path additionally runs in a fresh subprocess.