Resolve spherical radius from CRS datum - #19
Open
asinghvi17 wants to merge 2 commits into
Open
asinghvi17 wants to merge 2 commits into
asinghvi17 wants to merge 2 commits into
Conversation
asinghvi17
added this pull request to stack #18
September 20, 2026 20:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spherical table metadata previously preserved only GeometryOps' default radius. This adds an optional Proj extension that derives the radius from the supplied geographic CRS: a declared sphere retains its radius, and an ellipsoid uses
(2a+b)/3.GeoParquet
edgesstill selects planar or spherical interpretation. The existingGEOINTERFACE:crsvalue carries the datum unchanged; no new radius metadata or replacement CRS is introduced. Export andsetcrsvalidate radius agreement and reject projected CRS. Without a CRS, only the default spherical radius can round-trip.This builds on the spherical lookup and nearest-point PRs in the GitHub stack. Reprojection and cross-space raster operations remain outside this change.
Validation: datum tests (including a fresh process without Proj), spherical lookup tests (66 assertions), and spherical nearest tests (816 assertions) pass on the combined branch. The datum layer also passed the existing planar suite in its isolated worktree.
Geographic CRS checks and ellipsoid parsing live together in the Proj extension. The core uses the resulting radius for inference and checks radius agreement for explicit manifolds. The combined stack passes the full Julia 1.13 suite (2,470 assertions).