Skip to content

Mangle a Vararg whose length is still a TypeVar #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vchuravy wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

Mangle a Vararg whose length is still a TypeVar #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/mangling.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,14 @@ function mangle_param(@nospecialize(t), substitutions = Any[], top = false)
mangle_param(Base.unwrap_unionall(t), substitutions)
elseif isa(t, Core.TypeofVararg)
T = isdefined(t, :T) ? t.T : Any
if isdefined(t, :N)
# `N` is a `TypeVar` when the length is still parametric, which is what unwrapping a
# `UnionAll` such as `NTuple{N,Int}` leaves behind. There is no count to repeat then,
# so the type is mangled like the unbounded `Vararg{T}` it is equal to.
N = isdefined(t, :N) && isa(t.N, Integer) ? t.N : nothing
if N !== nothing
# For NTuple, repeat the type as needed
str = ""
for _ in 1:t.N
for _ in 1:N
str *= mangle_param(T, substitutions)
end
str
Expand Down
4 changes: 4 additions & 0 deletions test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ end
@test mangle(identity, Tuple{1, 2}, Tuple{}, Tuple) == "identity(Tuple<1, 2>, Tuple<>, Tuple)"
@test mangle(identity, NTuple{2, Int}) == "identity(Tuple<Int64, Int64>)"
@test mangle(identity, Tuple{Vararg{Int}}) == "identity(Tuple<>)"
# A `Vararg` whose length is still a `TypeVar`, which is what unwrapping a `UnionAll`
# leaves behind. It is the same type as the unbounded `Vararg` above, so it mangles alike.
@test mangle(identity, NTuple{N, Int} where {N}) == "identity(Tuple<>)"
@test mangle(identity, Val{NTuple{N, Int} where {N}}) == "identity(Val<Tuple<>>)"

# many substitutions
@test mangle(identity, Val{1}, Val{2}, Val{3}, Val{4}, Val{5}, Val{6}, Val{7}, Val{8},
Expand Down