Skip to content

Support complex pullbacks - #23

Draft
sethaxen wants to merge 1 commit into
JuliaDiff:masterfrom
sethaxen:complexpb
Draft

Support complex pullbacks#23
sethaxen wants to merge 1 commit into
JuliaDiff:masterfrom
sethaxen:complexpb

Conversation

@sethaxen

Copy link
Copy Markdown
Member

Replaces _dot with _realdot, which allows for pulling back through functions with complex outputs. Resolves #22. This is currently untested.

@codecov-commenter

codecov-commenter commented Oct 12, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.10%. Comparing base (b4343f5) to head (9bab121).
⚠️ Report is 66 commits behind head on master.

Files with missing lines Patch % Lines
src/AbstractDifferentiation.jl 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   78.26%   77.10%   -1.16%     
==========================================
  Files           1        1              
  Lines         345      345              
==========================================
- Hits          270      266       -4     
- Misses         75       79       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mohdibntarek

Copy link
Copy Markdown
Member

Could you please add a test here for the intended use case?

@sethaxen

sethaxen commented Jan 9, 2022

Copy link
Copy Markdown
Member Author

Certainly, though the tests need a few refactors first to make testing these cases more straightforward. Some changes made in #27. More will be necessary.

@sethaxen

sethaxen commented Jan 9, 2022

Copy link
Copy Markdown
Member Author

Also, this PR should use RealDot.jl now that it exists.

@gdalle
gdalle marked this pull request as draft September 20, 2023 11:11
@gdalle gdalle added the feature New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complex pullback support

4 participants