Skip to content

Fix newly introduced bug when opening Zarr arrays #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meggart wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix newly introduced bug when opening Zarr arrays #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1f2cc0
Fix newly introduced bug when opening Zarr arrays
meggart Mar 26, 2026
2c2db8f
Fix tests for zarr data and add test on to_dataset for Zgroup
felixcremer Mar 27, 2026
bbf0ce2
Fix tests
felixcremer Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "YAXArrayBase"
uuid = "90b8fcef-0c2d-428d-9c56-5f86629e9d14"
authors = ["Fabian Gans <fgans@bgc-jena.mpg.de>"]
version = "0.7.9"
version = "0.7.10"

[deps]
DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
Expand Down
5 changes: 4 additions & 1 deletion ext/ZarrExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ end
struct ZarrDataset
g::ZGroup
end
function ZarrDataset(g::String; mode="r", path="", kwargs...)
function ZarrDataset(g::Union{String,ZGroup}; mode="r", path="", kwargs...)
if g isa ZGroup
return ZarrDataset(g)
end
store = if endswith(g, "zip")
ZipStore(ZipReader(SimpleFileDiskArray(g)))
else
Expand Down
26 changes: 13 additions & 13 deletions test/datasets.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,19 @@ end
end

@testset "Reading Zarr" begin
p = "gs://cmip6/CMIP6/HighResMIP/CMCC/CMCC-CM2-HR4/highresSST-present/r1i1p1f1/6hrPlev/psl/gn/v20170706/"
ds_zarr = to_dataset(p,driver=:zarr)
vn = get_varnames(ds_zarr)
@test sort(vn) == ["lat", "lat_bnds", "lon", "lon_bnds", "psl", "time", "time_bnds"]
@test get_var_dims(ds_zarr, "psl") == ["lon", "lat", "time"]
@test get_var_dims(ds_zarr, "time") == ["time"]
@test get_var_dims(ds_zarr, "time_bnds") == ["bnds", "time"]
@test get_var_attrs(ds_zarr,"psl")["long_name"] == "Sea Level Pressure"
h = get_var_handle(ds_zarr, "psl")
@test YAXArrayBase.iscompressed(h)
@test all(isapprox.(h[1:2,1:2,1], [99360.8 99334.9; 99360.8 99335.4]))
@test allow_parallel_write(ds_zarr) == true
@test allow_missings(ds_zarr) == false
p = "https://s3.bgc-jena.mpg.de:9000/esdl-esdc-v3.0.2/esdc-16d-2.5deg-46x72x1440-3.0.2.zarr"
for ds_zarr in [to_dataset(p,driver=:zarr), to_dataset(zopen(p))]
vn = get_varnames(ds_zarr)
@test sort(vn) == ["aerosol_optical_thickness_550", "air_temperature_2m", "bare_soil_evaporation", "burnt_area", "cot", "cth", "ctt", "evaporation", "evaporation_era5", "evaporative_stress", "gross_primary_productivity", "interception_loss", "kndvi", "lat", "latent_energy", "lon", "max_air_temperature_2m", "min_air_temperature_2m", "nbar_blue", "nbar_green", "nbar_nir", "nbar_red", "nbar_swir1", "nbar_swir2", "nbar_swir3", "ndvi", "net_ecosystem_exchange", "net_radiation", "nirv", "open_water_evaporation", "potential_evaporation", "precipitation_era5", "radiation_era5", "root_moisture", "sensible_heat", "sif_gome2_jj", "sif_gome2_pk", "sif_gosif", "sif_rtsif", "sm", "snow_sublimation", "surface_moisture", "terrestrial_ecosystem_respiration", "time", "transpiration"]
@test get_var_dims(ds_zarr, "sm") == ["lon", "lat", "time"]
@test get_var_dims(ds_zarr, "time") == ["time"]
@test get_var_attrs(ds_zarr,"sm")["long_name"] == "Volumetric Soil Moisture"
h = get_var_handle(ds_zarr, "air_temperature_2m")
@test YAXArrayBase.iscompressed(h)
@test all(isapprox.(h[1:2,1:2,1], [-28.8662 -23.4534; -28.8041 -23.1681]))
@test allow_parallel_write(ds_zarr) == true
@test allow_missings(ds_zarr) == false
end
end
@testset "Reading ArchGDAL" begin
using ArchGDAL
Expand Down
Loading