Improve documentation of cache#124
Open
PatrickHaecker wants to merge 2 commits intoJuliaCollections:masterfrom
Open
Improve documentation of cache#124PatrickHaecker wants to merge 2 commits intoJuliaCollections:masterfrom
cache#124PatrickHaecker wants to merge 2 commits intoJuliaCollections:masterfrom
Conversation
Contributor
PatrickHaecker
commented
Feb 16, 2025
PatrickHaecker
commented
- fix typos
- fix typography
- improve wording
- split long lines
- fix typos - fix typography - improve wording - split long lines
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 90.72% 90.72%
=======================================
Files 1 1
Lines 399 399
=======================================
Hits 362 362
Misses 37 37 ☔ View full report in Codecov by Sentry. |
omus
reviewed
Feb 18, 2025
Contributor
omus
left a comment
omus
left a comment
There was a problem hiding this comment.
Looks like the rest of this docstring may be wrapped at 92-characters and not 80-characters
This was found during review by omus.
Contributor
Author
|
Friendly reminder: Anything to do to merge or close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.