Skip to content

fix: replace placeholder STL with real procedural mesh generator#3945

Closed
Kokila-chandrakar wants to merge 4 commits into
JhaSourav07:mainfrom
Kokila-chandrakar:fix/stl-real-mesh-generator
Closed

fix: replace placeholder STL with real procedural mesh generator#3945
Kokila-chandrakar wants to merge 4 commits into
JhaSourav07:mainfrom
Kokila-chandrakar:fix/stl-real-mesh-generator

Conversation

@Kokila-chandrakar
Copy link
Copy Markdown
Contributor

@Kokila-chandrakar Kokila-chandrakar commented Jun 5, 2026

Description

Replace the fake placeholder STL download with a real procedural 3D mesh generator.

Previously, the "Download Printable 3D STL Monolith" button simulated a 1.2s
loading delay and downloaded a hardcoded single-triangle STL file, which was
not a valid or printable 3D model.

This PR implements Option A from the issue:

  • Adds activityToTowers() in lib/export3d.ts to convert ActivityData[]
    into a TowerData[] grid, mapping contribution counts to mm heights
  • Wires handleDownloadSTL in ShareSheet.tsx to call the real
    generateMonolithSTL() instead of the placeholder
  • Adds 7 unit tests for activityToTowers in export3d.test.ts

Fixes #3676

Pillar

Bug Fix

Checklist

  • My code follows the project's coding style
  • I have added tests for my changes
  • All existing tests pass
  • I have updated relevant documentation
  • My PR title follows the conventional commits format

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 5, 2026

@Kokila-chandrakar is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the needs-details This PR is missing required description details. label Jun 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

👋 Hey @Kokila-chandrakar, it looks like you didn't use our PR template!

The section ## Description is missing from your PR description.

Please update your PR description to include all required sections so we can review this properly:

  • ## Description — What does this PR do? Which issue does it fix?
  • ## Pillar — Which contribution pillar does this fall under?
  • ## Checklist — Have you ticked off the quality checklist?

You can find the full template in CONTRIBUTING.md. Just edit your PR description and the needs-details label will be removed automatically. 🙌

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🚨 Hey @Kokila-chandrakar, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@github-actions github-actions Bot removed the needs-details This PR is missing required description details. label Jun 5, 2026
@Kokila-chandrakar Kokila-chandrakar force-pushed the fix/stl-real-mesh-generator branch from 8633511 to 6ef3d81 Compare June 5, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Fake STL Export (Feature Faking)

1 participant