Conversation
…perty handling. Remove deprecated `nullableProperty` utility.
MatkovIvan
approved these changes
May 27, 2026
Contributor
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
Public API change. Requires release notes + second approval
(and green CI)
igordmn
reviewed
May 27, 2026
| newInstance(T::class.java, *params) | ||
|
|
||
| @SuppressWarnings("UNCHECKED_CAST") | ||
| internal inline fun <reified T : Any> ObjectFactory.nullableProperty(): Property<T?> = |
Collaborator
There was a problem hiding this comment.
Did you check that all values that returned nullable are handled properly with isPresent or orNull?
| internal inline fun <reified T : Any> ObjectFactory.nullableProperty(): Property<T?> = | ||
| property(T::class.java) as Property<T?> | ||
|
|
||
| internal inline fun <reified T : Any> ObjectFactory.notNullProperty(): Property<T> = |
Collaborator
There was a problem hiding this comment.
notNull is misleading if all properties considered not null.
It looks like we can just rename it to property
| provider { | ||
| gradleProperty(prop).orNull | ||
| } | ||
| internal fun ProviderFactory.valueOrNull(prop: String): Provider<String> = |
Collaborator
There was a problem hiding this comment.
This is misleading now if we can't have null properties. Let's just remove it and use gradleProperty directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
nullablePropertytonotNullPropertyfor improved property handling. Remove deprecatednullablePropertyutility.Fixes https://youtrack.jetbrains.com/issue/CMP-10189
Release Notes
N/A