Updating how time offsets are applied, dealing with different start t… #1074
+38
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Plx
requested review from
baltzell,
efuchey,
ftouchte,
mathieuouillon,
mpaolone and
whit2333
as code owners
Collaborator
|
What's the reason for the |
Collaborator
Probably just for the convenience of null, which is just fine if it's not called much. But for a low-level "hit" class that gets instantiated a lot (?), keep in mind Float incurs more JVM memory garbage. |
baltzell
approved these changes
Jan 21, 2026
Collaborator
Author
|
Yes the float->Float is to be able to use null. Not sure what is safer memory-wise, I'm open to updating it if you have advice! |
N-Plx
added a commit
that referenced
this pull request
Jan 21, 2026
Collaborator
|
It's not about "safety", just memory usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…imes