Skip to content

fix: reduce string comparisons in ADC decoding, cleanup #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
baltzell wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: reduce string comparisons in ADC decoding, cleanup #1066

baltzell wants to merge 1 commit into from

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Jan 13, 2026 •
edited
Loading

Note, this assumes unique crate/slot/channel in all /daq/fadc CCDB tables. Now, the first match wins. Previously the last match won. For run 5038, the RF/LTCC::adc banks have a resulting difference.

@baltzell baltzell added the speed label Jan 13, 2026
@baltzell baltzell mentioned this pull request Jan 13, 2026
Closed
@baltzell baltzell changed the title reduce string comparisons, cleanup Reduce string comparisons in ADC decoding, cleanup Jan 13, 2026
@baltzell baltzell marked this pull request as ready for review January 13, 2026 20:43
@baltzell baltzell changed the title Reduce string comparisons in ADC decoding, cleanup fix: reduce string comparisons in ADC decoding, cleanup Jan 13, 2026
@baltzell baltzell mentioned this pull request Jan 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

speed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baltzell