Merged
Conversation
Collaborator
|
Hi @Bissmella ! I think you messed up your PR, can you please clean it up and regenerate your changes? |
Contributor
Author
|
Hi @dpascualhe, Oups yeah I see. I will fix it now. |
Bissmella
force-pushed
the
iou_parallelized
branch
from
c4fff84 to
6fe1f6b
Compare
Contributor
Author
|
now fixed. There was a confilct and resolving that had caused a mess. |
Collaborator
|
Good work with the conflict resolution but this comment is still not addressed:
Also, please just a single test per function, otherwise the test suite becomes really hard to maintain. Thanks for your efforts! |
Contributor
Author
|
I moved back the compute_iou, and shortened the test to a single function. |
dpascualhe
requested changes
Mar 20, 2026
Collaborator
dpascualhe
left a comment
dpascualhe
left a comment
There was a problem hiding this comment.
Looking better. Please format it using black and we are ready to go!
Contributor
Author
|
Formatted with black. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #377
This PR replaces the double for-loop implementation of
compute_iou_matrixandcompute_iouwith a fully vectorized Numpy broadcasting approach.Changes:
@dpascualhe
@Arkadeep455