Boss defeat state toggle support by 虞悖 - #172
Open
zlzhaidou wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr added a new feature make player can hold shift and right click to toggle boss or event's defeat state by enable a debug config
TODO: Old One's Army should be splited into three tiers
because Old One's Army have three independent fields
if marks them all as defeat or alive it may allow players to obtain items from beyond the current stage
also not useful for tester to test,buf due to I can't provide sprite and I'm not sure will this be merge so didn't split it yet
Multipalyer
During multiplayer, one player changed a boss's defeat state will broadcast to all players
this feature didn't support singleplayer because it will make the chat history mess
Why 1.4.5
this feature changed param list of Mod.Call,and 1.4.5 will be a nice chance to let every mod adapt this feature.
if release this feature in 1.4.4,other mod have to update to adapt