Fix EBS volume tagging for cost tracking#64
Open
cericg wants to merge 1 commit intoJaneliaSciComp:masterfrom
Open
Fix EBS volume tagging for cost tracking#64cericg wants to merge 1 commit intoJaneliaSciComp:masterfrom
cericg wants to merge 1 commit intoJaneliaSciComp:masterfrom
Conversation
AWS Batch ComputeResources.Tags only applies to EC2 instances, not attached EBS volumes. This causes untagged volumes (e.g., vol-096ac87ce5ec41606) which breaks cost tracking. Solution: Add an EC2 Launch Template with TagSpecifications that explicitly tags both 'instance' and 'volume' resource types at creation time. Changes: - Add AlignmentLaunchTemplate resource with TagSpecifications - Update ComputeAlignmentEnv to reference the launch template - Remove Tags property (now handled by launch template) Tags applied to both instances and volumes: - PROJECT, VERSION, DEVELOPER, STAGE (matches existing stackTags)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AWS Batch
ComputeResources.Tagsonly applies to EC2 instances, not attachedEBS volumes. This causes untagged volumes which breaks cost tracking.
Example:
vol-096ac87ce5ec41606- No tagsi-09cee327cbc3496ee- Tagged correctlySolution
Add an EC2 Launch Template with
TagSpecificationsthat explicitly tags bothinstanceandvolumeresource types at creation time.Changes
Add
AlignmentLaunchTemplateresourceTagSpecificationsto tag bothinstanceandvolumeresource typesUpdate
ComputeAlignmentEnvLaunchTemplatereferenceTagsproperty (now handled by launch template)Tags Applied (to both instances AND volumes)
config.ymlconfig.yml$USERenv varprovider.stageThese match the existing
stackTagsexactly, preserving cost tracking continuity.Testing
After deployment:
References