feat: SSHKeyContentResponse, SecretStr, authorized_keys options, and tests#302
Merged
krokicki merged 10 commits intoJaneliaSciComp:ssh-key-managerfrom Jan 28, 2026
Merged
Conversation
- Add ability to generate temporary SSH keys that are added to authorized_keys but private key is only shown once for copying - Add regenerate public key from private key functionality - Track id_ed25519 status (exists, unmanaged, missing pubkey) - Hide private key display in temp key dialog, only allow copy - Sort keys with id_ed25519 displayed first - Use clean 'fileglancer' comment when regenerating public keys Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Test coverage for functionality added in recent commits: - generate_temp_key_and_authorize with passphrase support - regenerate_public_key from private key - check_id_ed25519_status for managed/unmanaged detection - list_ssh_keys sorting (id_ed25519 first) - Umask restoration after key generation - TempKeyResponse header inclusion and temp file cleanup - _parse_authorized_keys_fileglancer filtering Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Note that this pull request is into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pydantic.SecretStrto guard ssh private key passwordrestrictandptykeyword to authorized_keys options. Consider whether Seqera needs aptyor not.fileglancerto authorized_keys commentQuestions: