fix(ci): install dev extras so pytest is available in datasets-refresh - #29
Open
grave0x wants to merge 1 commit into
Open
fix(ci): install dev extras so pytest is available in datasets-refresh#29grave0x wants to merge 1 commit into
grave0x wants to merge 1 commit into
Conversation
The weekly datasets-refresh run installs base deps only (pip install -e .) then runs 'python -m pytest', which fails with ModuleNotFoundError: No module named 'pytest' on every schedule hit. Install with the dev extra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly
datasets-refreshworkflow installs base deps only (pip install -e .) and then runspython -m pytest. Since pytest lives in thedevextra, every schedule hit fails at the unit-test step withModuleNotFoundError: No module named 'pytest'.Verified: fresh py3.11 venv,
pip install -e ".[dev]"→ all 22 tests intests/test_datasets.py,test_frr_scan.py,test_branding.py,test_relentless.pypass.One-line change: