Add structured MySQL CREATE TABLE partition parsing - #2521
Open
minleejae wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CREATE TABLE ... PARTITION BYfor HASH, KEY, RANGE, and LIST partitioning.CreateTable.getPartitioning()and the newTablePartitioningmodel.PartitionDefinitionwhile retaining its existing constructor and accessors.TablePartitioning.getPartitionOptions().Why
Valid MySQL partitioned table DDL currently either fails parsing or is consumed as unstructured table-option strings. This makes partition metadata unavailable to library users. The implemented grammar follows the MySQL 8.4
CREATE TABLEpartition syntax: https://dev.mysql.com/doc/refman/8.4/en/create-table.htmlHow
The parser now stops generic table-option capture at
PARTITION BY, builds a structured partitioning model, and renders it through bothCreateTable.toString()andCreateTableDeParser. Partition definitions supportVALUES LESS THAN,VALUES IN, unparenthesizedMAXVALUE, explicit subpartitions, and ENGINE/COMMENT/DIRECTORY/MAX_ROWS/MIN_ROWS/TABLESPACE options.Testing
./gradlew check --no-daemon --no-build-cache -Dorg.gradle.vfs.watch=falseMySQLCreateTablePartitionTest.CREATE TABLEstatements were executed successfully on MySQL 8.4.11.information_schema.PARTITIONSconfirmed HASH, LINEAR HASH, KEY, LINEAR KEY, RANGE, RANGE COLUMNS, LIST, LIST COLUMNS, and HASH/LINEAR KEY subpartition methods.Partially addresses #1668.
ALTER TABLEpartition operations remain a separate follow-up scope.AI assistance
OpenAI Codex was used to audit syntax coverage, draft the implementation, and run validation. The changes and generated tests were reviewed against the MySQL 8.4 documentation and a MySQL 8.4.11 server.