ci: run coco-dev-versions and import-specifiers drift checks in CI - #9928
ci: run coco-dev-versions and import-specifiers drift checks in CI#9928jeffrey701 wants to merge 1 commit into
Conversation
Superagent Supply Chain ScanSuperagent flagged 1 dependency introduced by this pull request. High risk:
|
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-30 01:30:44 UTC
Review summary Nits — 6 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Decision record
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9928 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 921 921
Lines 113270 113270
Branches 27301 27301
=======================================
Hits 104053 104053
Misses 7929 7929
Partials 1288 1288
Flags with carried forward coverage won't be shown. Click here to find out more. |
What
Two checks wired into
package.json'stest:ciare run by no GitHub Actions job, so they can onlyfail locally — the same "local-only-until-now" gap the many drift-check steps already in
.github/workflows/ci.ymlwere each added to close:coco-dev-versions:check— reconcilesk8s/coco-dev/versions.jsonwith the KBS kustomization'srecorded version. Nothing in
.github/workflows/referencesk8s, so no job or path filter ran it.import-specifiers:check(scripts: unify relative-import specifiers with src/** (extensionless) and add a drift guard #9221) — enforces the per-zone relative-import specifier convention oversrc,scripts,testand everypackages/*workspace. Not run by any job, and its test wasentirely injection-based —
#9240and#9249are two real drifts that reached main while the guard waslocal-only.
Change
.github/workflows/ci.yml: a newcocoDevpath-filter output (matchingk8s/coco-dev/**andscripts/check-coco-dev-versions*.ts) plus a Coco-dev versions check step gated on it; and anImport specifiers check step gated on
push || backend || mcp || engine || miner || discoveryIndex(every filter covering one of the checker's
BUNDLER_ROOTS/NODENEXT_ROOTS). Each step carries acomment naming the gap it closes, in the surrounding steps' style.
test/unit/check-import-specifiers-script.test.ts: a real-tree regression test that callsfindImportSpecifierViolations()with no injectedlistSourceFiles/readFileand asserts[]—mirroring the same real-tree guard
check-coverage-bolt-on-filenames-script.test.tsandvalidate-no-hand-written-js.test.tsalready have, with a comment naming chore(imports): packages/loopover-ui-kit drifted from #9221's extension convention (introduced by #9239) #9240/chore(imports): test/unit/engine-coverage-script.test.ts drifted from #9221's extension convention (introduced by #9245) #9249.Validation
npm run actionlintandnpm run lint:composite-actionspass on the edited workflow.checker reports comes from a source the checker excludes on CI —
node_modules/**(viaEXCLUDED_SEGMENT) and the two fixture-bearing files inALLOWED_FILENAMES(
check-import-specifiers-script.test.ts,check-dead-source-files-script.test.ts) — sofindImportSpecifierViolations()returns[], and the new test passes..github/workflows/**andscripts/**are outside Codecov'scoverage.include, so no patch-coverageobligation applies to the workflow edit.
Closes #9649