fix(review): key the generated skill's linked-issue trigger off gate mode

[bitfathers94]

fix(review): key the generated skill's linked-issue trigger off gate mode

hasStrictLinkedIssueRule fired on requireLinkedIssue + a non-optional
linkedIssuePolicy, which is advisory-only and never blocks a PR on its
own. That let the generated SKILL.md's trigger sentence say "a linked
issue is required" right above a Linked-issues section reporting
"Required: no" for the same repo. linkedIssueGateMode is the actual
enforcement authority (matches the identical assertion already used in
repo-doc-render.ts), so key off that instead.

Closes #9671

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-29 23:43:07 UTC}

3 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR fixes hasStrictLinkedIssueRule to key off linkedIssueGateMode === "block" (the actual enforcement authority) instead of requireLinkedIssue + non-optional linkedIssuePolicy, which was advisory-only and produced a self-contradictory generated SKILL.md (trigger sentence claiming a linked issue is required while the Linked-issues section said "Required: no"). The fix is well-targeted, matches the existing assertion pattern in repo-doc-render.ts, and is thoroughly tested across shouldGenerateRepoSkill, renderRepoSkillContent, and the integration test in repo-doc-pr.test.ts (including updating the manifest seed to set gate.linkedIssue: "block"). All existing test fixtures were correctly updated to include linkedIssueGateMode so the trigger conditions still fire where expected.

Nits — 3 non-blocking

• nit: repo-skill-render.ts:66's renderTriggerReasons still reads contributionWorkflow.linkedIssuePolicy in the trigger sentence even though the gate check no longer depends on it — worth double-checking that showing the raw policy string next to a gate-mode-driven trigger can't itself become confusing (e.g. policy: "preferred" with gateMode: "block").
• Consider a short comment near linkedIssueGateMode's declaration in repo-profile.ts (if not already present) reiterating that requireLinkedIssue/linkedIssuePolicy are advisory-only, since this is the second time (repo-doc-render.ts and now repo-skill-render.ts) that distinction had to be independently re-derived and fixed.
• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#9671
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	⚠️ 12/25	Preflight needs author follow-up before maintainer review.
Contributor workload	✅ 10/10	Author activity: 111 registered-repo PR(s), 77 merged, 1 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	bitfathers94; Gittensor profile; 111 PR(s), 1 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff changes hasStrictLinkedIssueRule to key off linkedIssueGateMode === "block" exactly matching repo-doc-render.ts's authority, leaves the :121 section untouched, and adds all four required named tests (both arms of the condition, the rendered-body regression tests for advisory and block modes, and the shouldGenerateRepoSkill threshold test).

Review context

• Author: bitfathers94
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: TypeScript
• Official Gittensor activity: 111 PR(s), 1 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Add a concise scope and risk note.
• Then work through the remaining 2 steps in the Signals table above.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.52%. Comparing base (45471e7) to head (6c89b4f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9924   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         281      281           
  Lines       58577    58577           
  Branches     6833     6833           
=======================================
  Hits        46581    46581           
  Misses      11706    11706           
  Partials      290      290           

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.