Skip to content

fix(miner-ui): type a chat-dispatch mock against the union #9815 closed #9846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 29, 2026
+6 −1
Merged

fix(miner-ui): type a chat-dispatch mock against the union #9815 closed #9846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/loopover-miner-ui/src/chat-conversation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { fireEvent, render, screen, waitFor } from "@testing-library/react";
import { describe, expect, it, vi } from "vitest";

import type { ChatActionDispatchResult } from "../../../packages/loopover-miner/lib/chat-action-dispatch.js";
import { createChatActionRegistry } from "../../../packages/loopover-miner/lib/chat-action-registry.js";
import { ChatConversation } from "./components/chat/conversation";
import { GOVERNOR_CHAT_ACTION_PENDING_MESSAGE } from "./lib/chat-governor-action-copy";
Expand Down Expand Up @@ -288,7 +289,11 @@ describe("ChatConversation governor pause/resume chat actions (#8670)", () => {
});

it("surfaces a non-executed dispatch (flag off / gated) as a system note instead of an empty turn", async () => {
const runGovernorChatActionImpl = vi.fn(async () => ({ ok: false, status: "disabled", action: null }));
const runGovernorChatActionImpl = vi.fn(async (): Promise<ChatActionDispatchResult> => ({
ok: false,
status: "disabled",
action: null,
}));
render(
<ChatConversation
streamChatImpl={async function* () {
Expand Down
Loading