Persona flag for doctor/pilot + tour command (#90, #91)#119
Merged
Conversation
Closes #87, #88, #95. - New `artifacts.py` registry: one place that names every scaffold artifact doctor/pilot recommend, with a <100-char rationale answering "what does this unlock?". Doctor's survey now reads from the registry and renders the rationale inline next to each artifact line. - New `docs/docs/wiki/Glossary.md` covering the terms users see in --help and doctor output (artifact, persona, MCP, skill, manifest, scope, maturity, ...). Linked from the wiki index, the top-level --help footer, and the doctor output footer so new users don't need to leave the CLI to interpret it. - New `cli_stability.py` registry tagging every top-level command as stable/preview/experimental. Markers render in --help next to each command name. Wiki `Stability.md` defines the contract per level. - Tests assert: every doctor artifact has a rationale, the Glossary covers the required terms, every visible --help command carries a registry entry, every marker is one of the three known levels.
Closes #90, closes #91. - New `personas.py` registry: four personas (beginner, control, security, team-lead) with focus area, prioritized artifact keys, and tailored next commands. Both `doctor --persona <name>` and `pilot --persona <name>` read from the same registry so the CLI cannot drift from the Team-Rollout wiki. - `doctor --persona security` reorders the artifact survey so policy / MCP / permissions appear first, switches the recommendation list to a focused policy/MCP recipe, and tightens the ignore-for-now to advanced surfaces that genuinely don't matter for a security review. - New `coding-scaffold tour` command: five-screen, stateless walkthrough (what the tool does -> artifact families -> doctor/pilot/setup loop -> daily session/eval/team workflow -> where to go next). No files written, no commands executed. Mentioned in the README "30-Second Start" as step 0. - Persona import-time validation: a typo in `Persona.artifact_keys` fails the module load instead of producing a silent KeyError at runtime. Stacked on top of #117 (the artifact registry is the persona registry's input).
83a0748 to
6702c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
personas.pyregistry: four personas (beginner,control,security,team-lead), each with a focus line, prioritized artifact keys, and a tailored recommendation list. Bothdoctor --persona <name>andpilot --persona <name>consume the same registry.doctor --persona securityreorders the artifact survey to surface policy / MCP / permissions first and swaps the recommendation list for a policy-focused recipe.coding-scaffold tourcommand: five-screen, stateless walkthrough (artifacts → doctor/pilot/setup → daily workflow → next). No files written; safe right after install. Linked from the README's 30-Second Start.Closes #90, closes #91.
Test plan
uv run pytest -q— 428 tests pass.tests/test_persona_and_tour.pycovers: registry invariants, doctor/pilot honor--persona, tour writes no files, tour content covers every artifact and ends with a recommended next command.python -m coding_scaffold tour --target .— renders five screens and ends withcoding-scaffold doctor.python -m coding_scaffold doctor --persona security --target .— reorders artifacts and prints policy/MCP/permissions-first recipe.