Fix batch ubun - #225
Merged
Merged
Conversation
jamesmarkchan
requested review from
JasmineRRod,
jslcom and
tylermlui
and
a lite review from Copilot
September 9, 2026 06:25
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Batch run cleanup can delete the wrong directory (or leave App.dataDir behind) after introducing per-drive resolved target locations.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR addresses Ubuntu batch-mode target directory handling by resolving each selected drive root to a user-writable location, and updates the batch UI/layout and theming so the batch workflow better matches the rest of the application.
Changes:
- Resolve per-drive writable benchmark locations (including Linux
/→$HOMEfallback) and use them during batch runs. - Update Batch Mode UI (results header removal, duration label placement, column alignment, and start/new-batch button styling).
- Minor version bump and documentation/theme touch-ups.
File summaries
| File | Description |
|---|---|
| README.md | Adds an Ubuntu-specific JDK install hint. |
| pom.xml | Bumps project revision to 0.9.0-rc2. |
| jdm-core/src/main/java/org/metricus/jdm/ui/theme/TrickOrTreatTheme.java | Adjusts focus/start button text color for the theme. |
| jdm-core/src/main/java/jdiskmark/Gui.java | Propagates theme start-button styling into the batch UI. |
| jdm-core/src/main/java/jdiskmark/DrivePanel.java | Delegates root-location resolution to DriveChecker. |
| jdm-core/src/main/java/jdiskmark/DriveChecker.java | Centralizes drive-root → writable-location resolution logic. |
| jdm-core/src/main/java/jdiskmark/BatchWorker.java | Validates/checks disk space against the resolved target location in batch runs. |
| jdm-core/src/main/java/jdiskmark/BatchPanel.java | UI/layout adjustments and table alignment; start/new-batch button styling support. |
| jdm-core/src/main/java/jdiskmark/BatchConfig.java | Applies resolved writable drive locations to App.locationDir/App.dataDir per run. |
| AGENT.md | Adds an additional guideline line on robust, maintainable code. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
looks good in full screen also, after some adjustments 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix batch mode for ubuntu
summary of changes: