Linux mounts - #222
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated lsblk parsing can still treat merged stderr output as device names, producing invalid /dev/... paths when lsblk fails.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Reviewed AGENT.md (loaded).
This PR improves Linux drive identification when a filesystem is mounted directly on a whole disk (no partition table), by avoiding empty lsblk pkname results and adding a fallback path to resolve the drive vendor/model.
Changes:
- Trim and skip empty lines returned by
lsblk -no pknamewhen mapping a partition to parent block devices. - In Linux drive-model detection, add a fallback to query vendor/model directly from the mounted device when no parent device name is returned.
File summaries
| File | Description |
|---|---|
| jdm-core/src/main/java/jdiskmark/UtilOs.java | Skips empty lsblk pkname output lines to avoid invalid device-name entries. |
| jdm-core/src/main/java/jdiskmark/Util.java | Adds fallback drive model lookup for whole-disk mounts where pkname is empty. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.