Skip to content

ufs-weather-model-env: remove base-env dependency/explicitly list deps; make nccmp, cprnc optional#2050

Draft
AlexanderRichert-NOAA wants to merge 2 commits into
JCSDA:developfrom
AlexanderRichert-NOAA:ufswm-metapkg-update-jul26
Draft

ufs-weather-model-env: remove base-env dependency/explicitly list deps; make nccmp, cprnc optional#2050
AlexanderRichert-NOAA wants to merge 2 commits into
JCSDA:developfrom
AlexanderRichert-NOAA:ufswm-metapkg-update-jul26

Conversation

@AlexanderRichert-NOAA

Copy link
Copy Markdown
Collaborator

Description

This PR updates ufs-weather-model-env, including a proposal to remove the dependency on base-env and list dependencies explicitly. Specifically, it reflects the list in https://github.com/ufs-community/ufs-weather-model/blob/develop/modulefiles/ufs_common.lua. It adds variants for including/excluding netcdf utilities (nccmp, cprnc) and build dependencies (cmake, python, git) so that developers can use this metapackage to install strictly the packages needed to build UFSWM with no frills.

Dependencies

none

Issues addressed

none

Applications affected

UFS Weather Model

Systems affected

all

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • test concretization of unified-dev and UFSWM only envs on Acorn

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

@climbfuji

Copy link
Copy Markdown
Collaborator

This is ok, we just need to make sure that this doesn't lead to duplicate packages in the unified environment (CI will tell)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants