Open
Conversation
reneemeyer
suggested changes
Aug 31, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
James, over all- really nice job. Just a few method questions/suggestions below. Also a note: it seems in your code you seem to take the long way around. Just because a method is available doesn't mean that you should use it. I like the idea of using classes, but there are a multitude of es6 array methods that would simply this code a lot and make it more effective. Now that the game works, I would refactor with the intent of getting rid of all for loops and all nested loops.
|
|
||
| class MasterMind { | ||
| constructor () { | ||
| // All Global Constants |
| processStart () { | ||
| // Clear board on restart - not first game | ||
| if (this.currentRow !== null) { | ||
| for (let row = 0; row < this.maxChecks; row++) { |
There was a problem hiding this comment.
How could you do this without using nested loops?
| // Determines remaining number of colors in the guess that match remaining | ||
| // colors in the solution | ||
| for (let guessIndex = 0; guessIndex < this.codeLength; guessIndex++) { | ||
| for (let solutionIndex = 0; solutionIndex < this.codeLength; solutionIndex++) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created Mastermind Visual as an object.