Ecosystem Integration: mysql_fdw - #302
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new docs include a hard-coded pg_config path and a minor table-format inconsistency that can mislead readers and should be normalized before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds bilingual (EN/CN) documentation for integrating mysql_fdw with IvorySQL, including validated version/compatibility notes, step-by-step installation/configuration, and navigation/ecosystem index updates so the new component is discoverable in the docs site.
Changes:
- Added new
mysql_fdwecosystem component pages in English and Chinese covering installation, MySQL setup, schema import, CRUD, UTF-8 handling, and pushdown validation. - Updated ecosystem overview tables (EN/CN) to list
mysql_fdwas a supported component. - Updated EN/CN navigation to include the new
mysql_fdwdocs page.
File summaries
| File | Description |
|---|---|
| EN/modules/ROOT/pages/master/ecosystem_components/mysql_fdw.adoc | New English mysql_fdw install/usage/validation/troubleshooting documentation. |
| EN/modules/ROOT/pages/master/ecosystem_components/ecosystem_overview.adoc | Adds mysql_fdw to the English ecosystem component compatibility list. |
| EN/modules/ROOT/nav.adoc | Adds mysql_fdw to the English navigation sidebar. |
| CN/modules/ROOT/pages/master/ecosystem_components/mysql_fdw.adoc | New Chinese mysql_fdw install/usage/validation/troubleshooting documentation. |
| CN/modules/ROOT/pages/master/ecosystem_components/ecosystem_overview.adoc | Adds mysql_fdw to the Chinese ecosystem component compatibility list. |
| CN/modules/ROOT/nav.adoc | Adds mysql_fdw to the Chinese navigation sidebar. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| export PG_CONFIG=/usr/local/ivorysql/bin/pg_config | ||
| make USE_PGXS=1 PG_CONFIG="$PG_CONFIG" | ||
| sudo make USE_PGXS=1 PG_CONFIG="$PG_CONFIG" install |
There was a problem hiding this comment.
Updated the example to use IVORYSQL_HOME with the RPM default path and a note to adjust it.
| | *30* | xref:master/ecosystem_components/set_user.adoc[set_user] | REL4_2_0 | PostgreSQL security auditing extension with controlled role switching, supporting allowlists, enforced auditing, and blocking of high-risk operations | Controlled role switching, privilege management, audit logging | ||
| | *31* | xref:master/ecosystem_components/mysql_fdw.adoc[mysql_fdw] | 2.9.3 | Foreign data wrapper for querying and modifying MySQL data from IvorySQL, with schema import and query pushdown | MySQL integration, federated queries, data migration |
There was a problem hiding this comment.
Normalized the new index cell to match the existing table format.
|
|
||
| export PG_CONFIG=/usr/local/ivorysql/bin/pg_config | ||
| make USE_PGXS=1 PG_CONFIG="$PG_CONFIG" | ||
| sudo make USE_PGXS=1 PG_CONFIG="$PG_CONFIG" install |
There was a problem hiding this comment.
Updated the example to use an adjustable IVORYSQL_HOME variable, with the RPM default shown.
|
🚀 IvorySQL-Docs Preview Ready
|
|
🚀 IvorySQL-Docs Preview Ready
|
Summary
Validation
Tested mysql_fdw 2.9.3 without source changes against the current
IVORY_REL_5_STABLE(IvorySQL 5.6 / PostgreSQL 18.6) and MySQL 8.4 on x86_64 Linux.CREATE EXTENSIONandIMPORT FOREIGN SCHEMA: passedThe released IvorySQL 5.4 image predates IvorySQL/IvorySQL#1448 and cannot build mysql_fdw 2.9.3; the documentation calls out this requirement explicitly.
Fixes IvorySQL/IvorySQL#1312