Fix for Fragment having constructor with parameters. #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew constructor with params
Ayyanchira
reviewed
Feb 9, 2026
Comment on lines
32
to
36
| * // Old (will crash): | ||
| * val fragment = IterableEmbeddedView(viewType, message, config) | ||
| * | ||
| * // New (production-ready): | ||
| * val fragment = IterableEmbeddedView.newInstance(viewType, message, config) |
Member
There was a problem hiding this comment.
will crash and new production ready can be changed with more subtle professional tone.
Ayyanchira
reviewed
Feb 9, 2026
Member
There was a problem hiding this comment.
Wow a dedicated class for arguments.
Contributor
Author
There was a problem hiding this comment.
Yeah that was a lot of variables and it really clustered the fragment, let me know if it is ok
Ayyanchira
approved these changes
Feb 9, 2026
Member
Ayyanchira
left a comment
Ayyanchira
left a comment
There was a problem hiding this comment.
Looks good. Added a nit pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
Root Cause
The
IterableEmbeddedViewfragment was using a constructor with parameters, which violates Android's Fragment lifecycle requirements. This causes crashes when the Android system attempts to recreate the fragment.Why This Happens
According to the official Android documentation:
When Android recreates fragments (during configuration changes, process death, or back stack operations), it uses reflection to call the empty constructor only. Any parameters passed through a custom constructor are lost, leaving properties uninitialized and causing crashes.
Official Android Best Practices
From the Android documentation on Creating a Fragment:
The Fix
Refactored
IterableEmbeddedViewto have newInstance with parameters and then bundle them up.Deprecating the fragment with arguments instead of making everything nullable, this way the variables better represent what is actually there.
The deprecation makes clients swap to the newInstance, but they can do with 1 click