Repository navigation
Fix the local-dev-cluster version bump in deploy.yaml - #179
Merged
Merged
Conversation
depot's local-dev-cluster Tiltfile now routes every image through a helper that
concatenates "FROM " onto a gcr= argument at runtime, so the sed's
`FROM ${IMG_NAME}` anchor never matched and the tag was silently left alone.
Match the bare image name, which still covers Tiltfiles spelling out
`FROM <name>:<tag>` inline.
The image name appears in that gcr= argument whether or not its tag changed, so
grep alone was enough to set changed=true on a no-op run. The push step then ran
git commit with nothing staged, exiting 1 and failing the job. Gate the flag on
cmp finding a real difference instead.
|
Merging this PR will move these workflow tags: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against abd8353 |
giarc3
approved these changes
Oct 8, 2026
coltfred
enabled auto-merge (squash)
October 8, 2026 20:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depot's local-dev-cluster Tiltfile now routes every image through a helper that concatenates "FROM " onto a gcr= argument at runtime, so the sed's
FROM ${IMG_NAME}anchor never matched and the tag was silently left alone. Match the bare image name, which still covers Tiltfiles spelling outFROM <name>:<tag>inline.The image name appears in that gcr= argument whether or not its tag changed, so grep alone was enough to set changed=true on a no-op run. The push step then ran git commit with nothing staged, exiting 1 and failing the job. Gate the flag on cmp finding a real difference instead.