fix(ci): release.yml explicitly dispatches docker-publish.yml - #555
Merged
Conversation
GITHUB_TOKEN-authored events (the \`gh release create\` in release.yml) never trigger other workflows — a GitHub Actions loop-prevention rule. docker-publish.yml's \`on: release: published\` trigger has therefore never fired once, for any prior release (confirmed via the Actions API: zero runs). release.yml now dispatches it explicitly with the version, so the resulting image gets real semver + latest tags instead of falling back to a bare :main branch tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GHCR images have never been auto-published for this repo — confirmed via the Actions API:
docker-publish.ymlshows zero runs, ever, across every prior release (v0.21.1–v0.21.5). Root cause:release.yml'sgh release createruns under the defaultGITHUB_TOKEN, and GitHub's loop-prevention rule means aGITHUB_TOKEN-authored event never triggers another workflow'son:trigger — sodocker-publish.yml'son: release: publishedsilently never fired.Fix:
release.ymlnow explicitly dispatchesdocker-publish.ymlviagh workflow run(exempt from the no-cascade rule) with the version as an input;docker-publish.ymlusesdocker/metadata-action'svalue=override so that dispatch produces the same semver +latesttags a native release event would, instead of falling back to a bare branch tag. No new secret required.Verified live (not just reasoned about): dispatched this branch's
docker-publish.ymlwithversion=0.21.6— the resulting image was tagged0.21.6,0.21, andlatestcorrectly.Test plan
-f version=0.21.6, confirmedDOCKER_METADATA_OUTPUT_TAGSincludes0.21.6/0.21/latestworkflow_dispatch(no version) still falls back to the branch tag — unchanged from before