Skip to content

fix: anticipate Rust 1.98 clippy warnings - #3485

Merged
Alenar merged 4 commits into
mainfrom
djo/rust_1.98
Aug 19, 2026
Merged

fix: anticipate Rust 1.98 clippy warnings#3485
Alenar merged 4 commits into
mainfrom
djo/rust_1.98

Conversation

@Alenar

@Alenar Alenar commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Content

This PR fix preemptively clippy lints added or updated with rust 1.98.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
    • No new TODOs introduced

Issue(s)

Closes #3484

@Alenar Alenar self-assigned this Aug 19, 2026
@Alenar Alenar added the dependencies 🔁 Updates dependencies label Aug 19, 2026

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions

Copy link
Copy Markdown

Test Results

     5 files  ± 0     209 suites  ±0   56m 4s ⏱️ - 1h 40m 37s
 3 398 tests  - 52   3 398 ✅  - 52  0 💤 ±0  0 ❌ ±0 
11 258 runs   - 55  11 258 ✅  - 55  0 💤 ±0  0 ❌ ±0 

Results for commit 17e2630. ± Comparison against base commit 58b575a.

This pull request removes 52 tests.
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_out_of_bounds
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_too_large_for_circuit_range
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::indices_not_increasing
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_merkle_path_mismatch
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_swap_keep_merkle_path
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_wrong_verification_key
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_corrupt_sibling
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_flip_position
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_long
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_short
…

@damrobi damrobi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar
Alenar deployed to testing-2-preview August 19, 2026 10:25 — with GitHub Actions Active
@Alenar
Alenar deployed to testing-preview August 19, 2026 10:25 — with GitHub Actions Active
@Alenar
Alenar merged commit 4ec7b25 into main Aug 19, 2026
75 of 80 checks passed
@Alenar
Alenar deleted the djo/rust_1.98 branch August 19, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies 🔁 Updates dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Rust to version 1.98

3 participants