feat(stm): add missing off circuit checks

[damrobi]

Content

This PR includes the addition of some missing off circuit checks. The goal of those checks is to prevent a prover from trying to create a proof that will fail to verify since the proof creation is a very expensive operations.

Changes

• Validation of the protocol message hash: it was not done off circuit yet but is done at every step in circuit. Recompute the hash of the protocol message preimage and compares it to the MessageHash received.
• Check of the validity of the genesis verification key: verifies the key is an actual point on the elliptic curve. The check is done at every step (even post genesis) in circuit.
• Check that the protocol parameters do not evolve from one epoch to the next: check that protocol_parameters == next_protocol_parameters for the values coming from the rolling state. An update of the parameters would break the recursive proof.
• Moved all the checks to before the generation of the non recursive proof to allow a failure before the heavy computation: This implied a big restructure of the code around the call to the IVC prover

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

Comments

Issue(s)

Closes #3381

[github-actions]

Test Results

     5 files  ± 0     209 suites  ±0   1h 38m 42s ⏱️ + 8m 59s
 3 429 tests  - 22   3 429 ✅  - 22  0 💤 ±0  0 ❌ ±0 
11 289 runs   - 22  11 289 ✅  - 22  0 💤 ±0  0 ❌ ±0 

Results for commit 1da401e. ± Comparison against base commit c8ff793.

♻️ This comment has been updated with latest results.

[hjeljeli32]

Good initial work 👍 . I left 2 comments.