Repository navigation
fix(builder): resolve committee cert redeemers to their certificate index - #714
Open
emmanuel-musau wants to merge 2 commits into
Open
emmanuel-musau wants to merge 2 commits into
emmanuel-musau wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Plutus-script committee cold credential could not authorize a hot credential or resign.
authCommitteeHotandresignCommitteeColdstore the redeemer undercert:{coldCredentialHash}, but neither the redeemer index lookup in assembly nor the certificate index map in evaluation matched the committee cold credential, so evaluation returned no results and the build failed.Both lookups now go through one
certCredentialhelper, which returns the stake, DRep or committee cold credential of a certificate.certScriptHashHexbuilds on it too, so one function knows which credential governs each certificate.The second commit makes assembly fail when a redeemer has no index, for every tag, instead of logging a warning and leaving the redeemer out of a transaction the node would reject.
mintAssetsregistered a redeemer for a policy whose amounts were all zero, which never enters the mint, so it now registers a policy only once it has a non-zero amount.Certificates that share one credential still share one
cert:{hash}redeemer; that is #713.Closes #518