Bs32 broken bib index - #348
Merged
Merged
Conversation
Top-level toc_hide:false keeps the section itself visible (Hugo merges a section's own cascade into its own Params, so cascade alone hid it), while cascade toc_hide:true keeps generated entries out of the nav. Removes the empty section-index.html override that suppressed subpage cards site-wide. Adds sidebar regression tests.
Explicit top-level toc_hide:false on the intake guide overrides the bibliography section's cascade (which Hugo merges into children's Params). Generated entries stay out via their own toc_hide. Extends the sidebar regression tests to cover both.
Subpage cards at the bottom of section pages are intentionally suppressed - navigation lives in the left pane. The sidebar regression tests now assert the cards stay absent.
|
Staging preview for this pull request is available at https://interlisp.github.io/Interlisp.staging/pr-348/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things broke. What the preview site was showing and what we ended up with after the merge were slightly different.
These changes are an immediate fix to get the bibliography entry into the leftside pane along with the intake guide. Changes have been validated locally...
Further investigation as to why the preview site was showing and the merge result diverged is next. And will be addressed as needed additional PRs.