Fix: Apply HTTPS redirection in non-Development environments#1145
Open
BenjaminMichaelis wants to merge 2 commits into
Open
Fix: Apply HTTPS redirection in non-Development environments#1145BenjaminMichaelis wants to merge 2 commits into
BenjaminMichaelis wants to merge 2 commits into
Conversation
- Inverted the IsDevelopment() check so UseHttpsRedirection middleware runs in Production/Staging - Previously middleware was only applied in Development, which is backwards - Now correctly enforces HTTPS in production deployments
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the ASP.NET Core middleware pipeline so HTTPS redirection is enforced outside Development, aligning production/staging behavior with the app’s security goals.
Changes:
- Inverted the environment check so
UseHttpsRedirection()runs in non-Development environments. - Preserves existing Development behavior (no HTTPS redirection applied).
- Add AddHttpsRedirection() service configuration with HttpsPort = 443 - Ensures middleware reliably enforces HTTPS redirects in production behind TLS-terminating proxy - Prevents silent failure of HTTPS redirection when port cannot be auto-detected - Positioned after AddTrustedForwardedHeaders() to group proxy-related configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HTTPS redirection middleware was only applied in Development environments due to an inverted conditional check. This allowed HTTP requests to be served in Production and Staging, defeating the purpose of enforcing HTTPS for security.
Solution
Inverted the environment check in
Program.cssoUseHttpsRedirection()now runs in non-Development environments (Production/Staging) instead of only in Development.Changes
Program.csline 551: changedif (app.Environment.IsDevelopment())toif (!app.Environment.IsDevelopment())Testing