-
Notifications
You must be signed in to change notification settings - Fork 23
Indexing routine to work with huge arrays #2721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
The tests were updated there to support run with pytest-run-parallel
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_51 ran successfully. |
Collaborator
vlad-perevezentsev
approved these changes
Jan 15, 2026
Contributor
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Jan 15, 2026
The PR enables compiling indexing extension with
`-fno-sycl-id-queries-fit-in-int` option to support huge arrays.
Otherwise there will be an exception raised:
```
> h_ev, choose_ev = indexing_ext._choose(inds, chcs, out, mode, q, dep_evs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E RuntimeError: Provided range and/or offset does not fit in int. Pass `-fno-sycl-id-queries-fit-in-int' to remove this limit.
```` 9218f1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR enables compiling indexing extension with
-fno-sycl-id-queries-fit-in-intoption to support huge arrays.Otherwise there will be an exception raised:
The tests validating the change are placed in
dpnp/tests/third_party/cupy/core_tests/test_ndarray_adv_indexing.pyand can be enabled when running pytest with-m slowoption.Also a bunch of third party tests were updated to keep in sync with the latest content.