Skip to content

chore(ci): unblock dependency bumps (Windows FFmpeg guard, vite client types) - #98

Merged
InstaZDLL merged 1 commit into
mainfrom
chore/unblock-dependency-bumps
Aug 9, 2026
Merged

chore(ci): unblock dependency bumps (Windows FFmpeg guard, vite client types)#98
InstaZDLL merged 1 commit into
mainfrom
chore/unblock-dependency-bumps

Conversation

@InstaZDLL

Copy link
Copy Markdown
Owner

Two blockers stood between the pending dependabot PRs and a merge.

Windows FFmpeg installs silently failed

choco install exits 0 when the Chocolatey community feed answers 503, so the Install FFmpeg step was reported green while installing nothing. The failure only surfaced five minutes later as nineteen integration tests panicking on ffmpeg: program not found — see run 31308831487 on ed4cf27, which turned main red.

This is a different cause from the August outage (where the step did not exist at all), but the same symptom, and it makes every Windows job a coin flip on the Chocolatey feed's health.

The step now retries the transient failure, then runs ffmpeg -version and ffprobe -version so it fails where the cause is.

webapp had no ambient Vite types

webapp/ has never shipped a vite-env.d.ts. TypeScript 5 tolerated the side-effect import of ./styles.css in main.tsx; TypeScript 7 rejects it:

src/main.tsx(25,8): error TS2882: Cannot find module or type declarations for
side-effect import of './styles.css'.

So #87 cannot pass CI as it stands, and dependabot cannot add the declaration itself.

Validation

Verified locally against the pending majors (vite 8.2.1, typescript 7.0.2, @vitejs/plugin-react 6.0.5): typecheck, biome check, 23 vitest tests and vite build all pass with this one-line declaration, and fail without it.

The four Cargo bumps (#89, #90, #92, #93) were also validated locally on this tree: they compile with no source change, 42 tests and clippy -D warnings are clean. For chacha20poly1305 0.10 → 0.11 I checked the stored format explicitly by sealing a secret with 0.10 and decrypting it with 0.11, since subsonic_credential rows are encrypted at rest — the format is unchanged.

Unblocks #86, #87, #88, #89, #90, #92, #93.

…ent types

Two blockers made dependency bumps unmergeable.

choco exits 0 when the Chocolatey community feed answers 503, so the Install
FFmpeg step reported success while installing nothing. The failure only
surfaced five minutes later as nineteen integration tests panicking on
"ffmpeg: program not found" (run 31308831487 on ed4cf27). Retry the transient
failure, then run ffmpeg -version and ffprobe -version so the step fails where
the cause actually is.

webapp has never had a vite-env.d.ts. TypeScript 5 tolerated the side-effect
import of ./styles.css in main.tsx; TypeScript 7 rejects it with TS2882, so the
pending typescript bump cannot pass CI without this declaration. Dependabot
cannot add the file itself.

Claude-Session: https://claude.ai/code/session_01NJBwjsQ17Bx2PgvPbBGNpM
Signed-off-by: InstaZDLL <github.105mh@8shield.net>
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1e516e01-6960-4bd8-ab0b-63c663b1db65

📥 Commits

Reviewing files that changed from the base of the PR and between 6716df9 and 8fa97af.

📒 Files selected for processing (2)
  • .github/workflows/ci-rust.yml
  • webapp/src/vite-env.d.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added scope: web Embedded web player (React) scope: tooling Build / dev tooling size: s 10-50 lines ignore-for-release Excluded from release notes labels Aug 9, 2026
@InstaZDLL
InstaZDLL merged commit f2492a8 into main Aug 9, 2026
12 checks passed
@InstaZDLL
InstaZDLL deleted the chore/unblock-dependency-bumps branch August 9, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Excluded from release notes scope: tooling Build / dev tooling scope: web Embedded web player (React) size: s 10-50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant