chore(ci): unblock dependency bumps (Windows FFmpeg guard, vite client types) - #98
Conversation
…ent types Two blockers made dependency bumps unmergeable. choco exits 0 when the Chocolatey community feed answers 503, so the Install FFmpeg step reported success while installing nothing. The failure only surfaced five minutes later as nineteen integration tests panicking on "ffmpeg: program not found" (run 31308831487 on ed4cf27). Retry the transient failure, then run ffmpeg -version and ffprobe -version so the step fails where the cause actually is. webapp has never had a vite-env.d.ts. TypeScript 5 tolerated the side-effect import of ./styles.css in main.tsx; TypeScript 7 rejects it with TS2882, so the pending typescript bump cannot pass CI without this declaration. Dependabot cannot add the file itself. Claude-Session: https://claude.ai/code/session_01NJBwjsQ17Bx2PgvPbBGNpM Signed-off-by: InstaZDLL <github.105mh@8shield.net>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
Two blockers stood between the pending dependabot PRs and a merge.
Windows FFmpeg installs silently failed
choco installexits 0 when the Chocolatey community feed answers 503, so theInstall FFmpegstep was reported green while installing nothing. The failure only surfaced five minutes later as nineteen integration tests panicking onffmpeg: program not found— see run 31308831487 oned4cf27, which turnedmainred.This is a different cause from the August outage (where the step did not exist at all), but the same symptom, and it makes every Windows job a coin flip on the Chocolatey feed's health.
The step now retries the transient failure, then runs
ffmpeg -versionandffprobe -versionso it fails where the cause is.webapphad no ambient Vite typeswebapp/has never shipped avite-env.d.ts. TypeScript 5 tolerated the side-effect import of./styles.cssinmain.tsx; TypeScript 7 rejects it:So #87 cannot pass CI as it stands, and dependabot cannot add the declaration itself.
Validation
Verified locally against the pending majors (vite 8.2.1, typescript 7.0.2, @vitejs/plugin-react 6.0.5): typecheck,
biome check, 23 vitest tests andvite buildall pass with this one-line declaration, and fail without it.The four Cargo bumps (#89, #90, #92, #93) were also validated locally on this tree: they compile with no source change, 42 tests and
clippy -D warningsare clean. Forchacha20poly13050.10 → 0.11 I checked the stored format explicitly by sealing a secret with 0.10 and decrypting it with 0.11, sincesubsonic_credentialrows are encrypted at rest — the format is unchanged.Unblocks #86, #87, #88, #89, #90, #92, #93.