ENH: Add ConnectedComponentImageFilter test baseline CID blobs (3 files, 15.4 KiB)#38
Merged
hjmjohnson merged 1 commit intoApr 27, 2026
Conversation
Three new CIDv1-raw blobs (15.4 KiB total) used as updated baselines for the four `itkConnectedComponentImageFilterTest*` tests modified by InsightSoftwareConsortium/ITK#5836, which replaces `std::uniform_int_distribution` in the colormap RNG with an explicit modulo expression so test output is reproducible across libstdc++ / libc++ / MSVC. Blobs: bafkreibyjpytxv46k6mkxo3sadppjvs6b5vjqwqcz6u4vkzpp2btmge4fm 6655 B ConnectedComponentImageFilterTest.png (also reused by ...TestRGB) bafkreif6vtfmpapapqk5q5xlitj7g72pdihcrrncdf5cwgtnexu36cj6rm 5182 B ConnectedComponentImageFilterTest2.png bafkreibxbxqmcg73nig3ncv7gt2rqdcj7nfw72r3be4r6l5llmqw4wpwru 3015 B ConnectedComponentImageFilterTest3.png Generated locally on macOS 15 / Apple Clang Release build of ITK with PR #5836 applied. Workaround for the broken content-link-upload.itk.org service tracked in InsightSoftwareConsortium/cmake-w3-externaldata-upload#3. IPFS pinning could not be performed in this session (no local Kubo node); pin/replicate from a maintainer's node before merging the companion ITK PR that updates the .cid content links.
hjmjohnson
merged commit d89fd19
into
InsightSoftwareConsortium:gh-pages
1 check passed
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 27, 2026
…istic RNG The previous commit replaced std::uniform_int_distribution with a direct modulo expression so that std::mt19937 output is reduced identically across libstdc++ / libc++ / MSVC. Update the four test baselines to the new deterministic output and drop the per-platform .1 alternates that existed only to paper over the prior cross-stdlib divergence. Three new CIDs land via InsightSoftwareConsortium/ITKTestingData#38: Test.png (also reused by ...TestRGB) bafkreibyjpytxv46k6mkxo3sadppjvs6b5vjqwqcz6u4vkzpp2btmge4fm Test2.png bafkreif6vtfmpapapqk5q5xlitj7g72pdihcrrncdf5cwgtnexu36cj6rm Test3.png bafkreibxbxqmcg73nig3ncv7gt2rqdcj7nfw72r3be4r6l5llmqw4wpwru Verified locally on macOS 15 / Apple Clang Release: all four itkConnectedComponentImageFilterTest{,RGB,2,3} tests pass against the new primary baselines with no fall-through to alternates.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 27, 2026
…istic RNG The previous commit replaced std::uniform_int_distribution with a direct modulo expression so that std::mt19937 output is reduced identically across libstdc++ / libc++ / MSVC. Update the four test baselines to the new deterministic output and drop the per-platform .1 alternates that existed only to paper over the prior cross-stdlib divergence. Three new CIDs land via InsightSoftwareConsortium/ITKTestingData#38: Test.png (also reused by ...TestRGB) bafkreibyjpytxv46k6mkxo3sadppjvs6b5vjqwqcz6u4vkzpp2btmge4fm Test2.png bafkreif6vtfmpapapqk5q5xlitj7g72pdihcrrncdf5cwgtnexu36cj6rm Test3.png bafkreibxbxqmcg73nig3ncv7gt2rqdcj7nfw72r3be4r6l5llmqw4wpwru Verified locally on macOS 15 / Apple Clang Release: all four itkConnectedComponentImageFilterTest{,RGB,2,3} tests pass against the new primary baselines with no fall-through to alternates.
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 27, 2026
…istic RNG The previous commit replaced std::uniform_int_distribution with a direct modulo expression so that std::mt19937 output is reduced identically across libstdc++ / libc++ / MSVC. Update the four test baselines to the new deterministic output and drop the per-platform .1 alternates that existed only to paper over the prior cross-stdlib divergence. Three new CIDs land via InsightSoftwareConsortium/ITKTestingData#38: Test.png (also reused by ...TestRGB) bafkreibyjpytxv46k6mkxo3sadppjvs6b5vjqwqcz6u4vkzpp2btmge4fm Test2.png bafkreif6vtfmpapapqk5q5xlitj7g72pdihcrrncdf5cwgtnexu36cj6rm Test3.png bafkreibxbxqmcg73nig3ncv7gt2rqdcj7nfw72r3be4r6l5llmqw4wpwru Verified locally on macOS 15 / Apple Clang Release: all four itkConnectedComponentImageFilterTest{,RGB,2,3} tests pass against the new primary baselines with no fall-through to alternates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three new baseline blobs needed by ITK#5836 (Remove
std::uniform_int_distributionfromConnectedComponentImageFiltertests). Workaround for the broken content-link-upload.itk.org service.Note: I do not have a local Kubo node, so these blobs are committed but not yet pinned to IPFS. A maintainer with
ipfsaccess should pin/replicate before the companion ITK PR updates the.cidcontent links.Blobs added
bafkreibyjpytxv46k6mkxo3sadppjvs6b5vjqwqcz6u4vkzpp2btmge4fmitkConnectedComponentImageFilterTest,itkConnectedComponentImageFilterTestRGBbafkreif6vtfmpapapqk5q5xlitj7g72pdihcrrncdf5cwgtnexu36cj6rmitkConnectedComponentImageFilterTest2bafkreibxbxqmcg73nig3ncv7gt2rqdcj7nfw72r3be4r6l5llmqw4wpwruitkConnectedComponentImageFilterTest3Test.pngandTestRGB.pngare byte-identical (same RNG seed, same colormap), so only three unique blobs are needed for the four updated tests.How the blobs were generated
upstream/main.Module_ITKConnectedComponents=ON, fetched ExternalData (ninja ITKData).ITKConnectedComponentsTestDriver.ctest -R '^itkConnectedComponentImageFilterTest(|RGB|2|3)$'.Testing/Temporary/ITKConnectedComponents/.