Skip to content

tests: wait for the reload status in TestManager_ReloadStatus - #55

Merged
Insei merged 1 commit into
mainfrom
fix-reload-status-test
Oct 19, 2026
Merged

Insei merged 1 commit into
mainfrom
fix-reload-status-test

Conversation

@Insei

@Insei Insei commented Oct 19, 2026

Copy link
Copy Markdown
Owner

TestManager_ReloadStatus failed sometimes in CI: ReloadStatus is updated after the subscribers of all configs are called, and the test read it right after its subscriber was called. The test waits for the status now. Checked with 50 runs with the race detector and 30 runs on Go 1.19.

…s are called

Signed-off-by: Dmitriy Aleksandrov <goodmobiledevices@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7e2b443) to head (f4aa214).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         2630      2638    +8     
=========================================
+ Hits          2630      2638    +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark diff: 5f9bf99 → 444fb85 (10 runs)

goos: linux
goarch: amd64
pkg: github.com/insei/tinyconf/v2
cpu: AMD EPYC 7763 64-Core Processor                
                    │  base.txt   │              head.txt              │
                    │   sec/op    │   sec/op     vs base               │
Parse-4               3.382µ ± 1%   3.417µ ± 4%  +1.02% (p=0.002 n=10)
Parse_SubConfig-4     1.581µ ± 1%   1.561µ ± 2%  -1.30% (p=0.014 n=10)
Current-4             55.68n ± 0%   55.25n ± 0%  -0.76% (p=0.000 n=10)
Current_SubConfig-4   99.23n ± 1%   98.31n ± 0%       ~ (p=0.529 n=10)
geomean               414.6n        412.5n       -0.50%

                    │    base.txt    │               head.txt                │
                    │      B/op      │     B/op      vs base                 │
Parse-4               1.344Ki ± 0%     1.344Ki ± 0%       ~ (p=1.000 n=10) ¹
Parse_SubConfig-4       392.0 ± 0%       392.0 ± 0%       ~ (p=1.000 n=10) ¹
Current-4               0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
Current_SubConfig-4     0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                            ²                 +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │   base.txt   │              head.txt               │
                    │  allocs/op   │ allocs/op   vs base                 │
Parse-4               18.00 ± 0%     18.00 ± 0%       ~ (p=1.000 n=10) ¹
Parse_SubConfig-4     10.00 ± 0%     10.00 ± 0%       ~ (p=1.000 n=10) ¹
Current-4             0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
Current_SubConfig-4   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                          ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/insei/tinyconf/v2/drivers
                │  base.txt   │           head.txt            │
                │   sec/op    │   sec/op     vs base          │
Parse_Drivers-4   59.84µ ± 1%   60.14µ ± 1%  ~ (p=0.105 n=10)

                │   base.txt   │            head.txt            │
                │     B/op     │     B/op      vs base          │
Parse_Drivers-4   25.14Ki ± 0%   25.14Ki ± 0%  ~ (p=1.000 n=10)

                │  base.txt  │            head.txt            │
                │ allocs/op  │ allocs/op   vs base            │
Parse_Drivers-4   408.0 ± 0%   408.0 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@Insei
Insei merged commit c9f6a41 into main Oct 19, 2026
4 checks passed
@Insei
Insei deleted the fix-reload-status-test branch October 19, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants