Skip to content

Add XML to all classes in the Card folder, add GainMultipleGems ability class - #343

Open
HumabHatterZed wants to merge 42 commits into
InscryptionModding:Update-Installation-Guides-and-Documentation-and-Bug-Fixesfrom
HumabHatterZed:xml
Open

HumabHatterZed wants to merge 42 commits into
InscryptionModding:Update-Installation-Guides-and-Documentation-and-Bug-Fixesfrom
HumabHatterZed:xml

Conversation

@HumabHatterZed

Copy link
Copy Markdown
Contributor

Adds all missing XML to classes contained in the API's Card subfolder.

Also adds GainMultipleGems, an ability subclass that allows for modders to create sigils that provide multiple gem colours instead of just one or all three.

**Comment out unusued duplicate field**
Considering if the custom costs ID system can be deprecated, but it may have a use as a way of providing custom cost adjustments on CardModInfos
…verse key-value pair of currentSacrificedCardInfos, add XML

@Chaosyr Chaosyr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its of use, the following contains common XML tags that can be used and how to use them. https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/xmldoc/recommended-tags

This PR is good once the two items mentioned are fixed across the module ^^

@Chaosyr Chaosyr self-assigned this Nov 13, 2026
Add some missing XML and fix incorrect XML in AbilityExtensions

@Chaosyr Chaosyr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix these areas, otherwise looks good thus far ^^

Comment thread InscryptionAPI/Card/AbilityManager.cs Resolved

@Chaosyr Chaosyr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna wait till im given the go ahead to merge but this looks good ^^

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants