Repository navigation
Add way to easily patch and modify the default bone gain when a player's card dies - #341
Conversation
…ies i do NOT need seventy million copies of unity asms on my pc
|
Also a better fix for commit A of this PR is in: a58736c |
There was a problem hiding this comment.
Please implement the XML Comments, Ideally also base off #338 at minimum for the CSProj's.
Alternatively make a new PR to this branch instead with your changes: https://github.com/InscryptionModding/InscryptionAPI/tree/Update-Installation-Guides-and-Documentation-and-Bug-Fixes
|
For record the new branch I edited into the change request is going to be the basis of the next update, the goal with it is to get the API properly documented internally, thus I want any new code to be documented ^^ Along with that already started a Changelog for it as well: https://github.com/InscryptionModding/InscryptionAPI/blob/cbe00db831f50e9734520dcf767f4d42f8f179a7/CHANGELOG.md |
|
Will add the XML documentation and undo the changelog changes to avoid merge conflicts. Not sure what you mean by 'Commit A' - does that refer to the file compiling fix? If so, I'll revert that stuff too. |
Yup that would be what it refers to ^^ |
…xes' into bone-hooks
|
Alright everything should be good lmk if anything else needs to be done. |
|
@HumabHatterZed I can merge now unless you have anything else you wanna bundle into this PR |
Implement PR Changelog
|
I'm done with this particular PR. |
908b1a8
into
InscryptionModding:Update-Installation-Guides-and-Documentation-and-Bug-Fixes

Adds a new class
DefaultBoneGainOnDeathand methodsDefaultBoneGainOnDeath.ShouldDoDefaultBoneGainandDefaultBoneGainOnDeeath.DoDefaultBoneGainto the API that basically expose specific parts of the PlayableCard.Die method's code.These allow modders to patch and modify the default bone gain within the PlayableCard.Die method without needing to patch ResourcesManager.AddBone directly.
changelog:
DefaultBoneGainOnDeathand methodsDefaultBoneGainOnDeath.ShouldDoDefaultBoneGainandDefaultBoneGainOnDeeath.DoDefaultBoneGain