Skip to content

Add way to easily patch and modify the default bone gain when a player's card dies - #341

Merged
Chaosyr merged 10 commits into
InscryptionModding:Update-Installation-Guides-and-Documentation-and-Bug-Fixesfrom
HumabHatterZed:bone-hooks
Oct 30, 2026
Merged

Chaosyr merged 10 commits into
InscryptionModding:Update-Installation-Guides-and-Documentation-and-Bug-Fixesfrom
HumabHatterZed:bone-hooks

Conversation

@HumabHatterZed

@HumabHatterZed HumabHatterZed commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Adds a new class DefaultBoneGainOnDeath and methods DefaultBoneGainOnDeath.ShouldDoDefaultBoneGain and DefaultBoneGainOnDeeath.DoDefaultBoneGain to the API that basically expose specific parts of the PlayableCard.Die method's code.

These allow modders to patch and modify the default bone gain within the PlayableCard.Die method without needing to patch ResourcesManager.AddBone directly.

changelog:

  • Added way to easily patch and modify the default bone gain when a player's card dies
  • Added class DefaultBoneGainOnDeath and methods DefaultBoneGainOnDeath.ShouldDoDefaultBoneGain and DefaultBoneGainOnDeeath.DoDefaultBoneGain

@Chaosyr

Chaosyr commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Also a better fix for commit A of this PR is in: a58736c

@Chaosyr Chaosyr left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the XML Comments, Ideally also base off #338 at minimum for the CSProj's.

Alternatively make a new PR to this branch instead with your changes: https://github.com/InscryptionModding/InscryptionAPI/tree/Update-Installation-Guides-and-Documentation-and-Bug-Fixes

@Chaosyr

Chaosyr commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

For record the new branch I edited into the change request is going to be the basis of the next update, the goal with it is to get the API properly documented internally, thus I want any new code to be documented ^^

Along with that already started a Changelog for it as well: https://github.com/InscryptionModding/InscryptionAPI/blob/cbe00db831f50e9734520dcf767f4d42f8f179a7/CHANGELOG.md

@HumabHatterZed

Copy link
Copy Markdown
Contributor Author

Will add the XML documentation and undo the changelog changes to avoid merge conflicts. Not sure what you mean by 'Commit A' - does that refer to the file compiling fix? If so, I'll revert that stuff too.

@Chaosyr

Chaosyr commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Will add the XML documentation and undo the changelog changes to avoid merge conflicts. Not sure what you mean by 'Commit A' - does that refer to the file compiling fix? If so, I'll revert that stuff too.

Yup that would be what it refers to ^^

@Chaosyr

Chaosyr commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator
image for record when you go to edit the title of the PR you can also edit the Branch the PR targets jsyn ^^

@HumabHatterZed
HumabHatterZed changed the base branch from main to Update-Installation-Guides-and-Documentation-and-Bug-Fixes October 30, 2026 04:48
@HumabHatterZed

Copy link
Copy Markdown
Contributor Author

Alright everything should be good lmk if anything else needs to be done.

@Chaosyr

Chaosyr commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

@HumabHatterZed I can merge now unless you have anything else you wanna bundle into this PR

Implement PR Changelog
@HumabHatterZed

Copy link
Copy Markdown
Contributor Author

I'm done with this particular PR.

@Chaosyr
Chaosyr merged commit 908b1a8 into InscryptionModding:Update-Installation-Guides-and-Documentation-and-Bug-Fixes Oct 30, 2026
1 check passed
@HumabHatterZed
HumabHatterZed deleted the bone-hooks branch November 13, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants