[RealMAX] Fix track pause with Tidal Connect#224
Merged
Inrixia merged 4 commits intoInrixia:masterfrom Mar 4, 2026
Merged
Conversation
2 tasks
b928506 to
ebb26b4
Compare
Inrixia
requested changes
Mar 2, 2026
Owner
Inrixia
left a comment
There was a problem hiding this comment.
This is awesome!
Only one thing I'd like to be fixed if possible. Otherwise happy to merge this, thanks for the help 💜
Owner
|
Awesome work, thanks so much for this! 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This effectively addresses #222 - RealMAX caused every track to pause when switching via Tidal Connect.
Problem
Two issues with Tidal Connect:
onPreMediaTransitionhandler calledPlayState.pause()+PlayState.play()unconditionally on every transition, even when no HiRes replacement was found. In Tidal Connect, this unnecessary pause/play cycle caused a race condition with the remote device, leaving tracks paused.MOVEinterceptors usedPlayState.updatePlayQueue()to swap the currently playing track'smediaItemId, which doesn't properly start playback on the Tidal Connect remote device. The local state reportedplaying=truebut the remote device was paused.Changes
MOVEinterceptors: Pre-swap the max version at the target index in the queue (keepingcurrentIndexunchanged so the currently playing track is not disrupted), then usePlayState.next()/previous()/moveTo()to transition through Tidal Connect's normal playback mechanism. No extraPlayState.play()call afterward.onPreMediaTransition: Only performpause()/playNext()/play()when a HiRes replacement is actually found. Skip it entirely when no replacement exists.How to test
Tested locally: