feat: promote discover-your-innersource#780
Conversation
fix: correct improve-findability.md link
…he file, as per the pattern template
spier
left a comment
There was a problem hiding this comment.
I pushed some changes to align the pattern with our pattern template.
Overall I think this is an interesting pattern, that has some way to go before being ready to be published to our book though.
My main concerns right now are:
- The Solution section contains multiple different things. What are the core aspects of the solution? Maybe we could try to group the bullets into categories, and give each category a distinct name to find out what the overarching themes of the solution are.
- How is this pattern related to other patterns like InnerSource Portal and Gig Marketplace?
- Not sure what to do with the "Discussion on" section. this seems more like meeting notes from a discussion that must have happened a long time ago. Maybe we can ask people that are still around if they remember anything about this pattern, like @gruetter and @NewMexicoKid
Besides that, we would have to check the requirements here before publishing to the book: Contributor Handbook - Requirements for maturity 'Structured'
If the ambition here is to have a better version of this pattern merged into our repo, I would recommend to leave this in the Initial state (and folder) for a bit longer. This would allow us to make some fixes and merge these PRs faster.
If the ambition is to get this pattern live in our book, then we will have to invest quite some work here and keep the PR open for a while.
Either way is fine with me, I just want to prevent frustrations as I don't know what your expectations are here.
|
Btw @jeffabailey if you want to use this pattern as a way to learn what it takes to get a pattern ready for publication in the book, by all means, keep pushing :) Just it might not be the easiest path on this particular pattern, as the current content of the pattern leaves a lot of room for improvement. |
Awesome, thank you!
This, TBH! :)
Sounds like a great challenge and learning opportunity. I'll read through more of the published patterns to align this one closer to the others. I was having a conversation with @rrrutledge about what constitutes an approachable and useful pattern. The patterns listed on the fearless change website are an interesting overlay to the patterns. https://fearlessjourney.info/fearless-change-patterns/ I really like "Discover Your InnerSource" name for the pattern. What do you think about the name?
Another great question to answer after defining the appropriate name and scope for this pattern. |
|
@jeffabailey I took some liberties and added the checklist for maturity Structured to the initial message of this PR. That gives us some guidelines for the various things that we want to check before promoting this pattern to our book. |
spier
left a comment
There was a problem hiding this comment.
The biggest challenge I see in this pattern at the moment is the Solution section.
- Some of the bullets in the Solution section propose things that already exist as dedicated patterns. We could link to them.
- Aside: this is not surprizing as some of those other patterns might have not existed 8 years ago when this pattern was drafted
- Through that we might also figure what is the "net new" content in this pattern.
- How is this pattern related to these patterns
I suspect my comments may seem overly critical of this pattern.
However my goal is to only publish useful patterns to the book. And given that this pattern has not been touched in so long, it will need a bit of love/work to be ready for prime time :)
Co-authored-by: Isabel Drost-Fromm <isabel.drostfromm@gmail.com>
|
@jeffabailey it has been some time since I looked at this PR, so I have forgotten a bit what we talked about before. To confirm: You are pushing to get this pattern published in the book, right? i.e. get it to maturity structured? I read the pattern again. My sense is that if we would focus this pattern on the behavior change only, then this might make things easier for us. If necessary, we can move elements from this pattern that relate to tooling into the InnerSource Portal pattern instead. What do you think about that approach? |
Sounds like a good approach to me. |
…ailey/InnerSourcePatterns into promote-discover-your-innersource
|
Moved the pattern back to 1-initial, and I'll make another attempt in a new PR since this one went wild. 🐅 @spier any concerns with merging this since it won't be promoted to structured? |
Thanks for pushing this @jeffabailey. Sounds good! Looking forward to the new PR. |
This pattern has been around in a draft/initial stage for a long time (almost 8 years)!
As we believe that it does add some interest points, we want to try to improve it so that we feel comfortable publishing it in our pattern book.
Checklist
from the Contributor Handbook:
Extras
History